Layla Ghaffari

Results 41 comments of Layla Ghaffari

> wouldn't we expect this to converge under refinement? I remember we didn't see convergence with `-degree 2` in the summer. I only presented degree 1 in my talk.

> Also, the domain shape (`dm_plex_box_upper 125,125,250`) relative to resolution `dm_plex_box_faces 5,5,1` looks weird. I took the arguments from the regression tests in `navierstokes.c` (and refined it) to show you...

> how does isentropic vortex test your `to_prim` conversion if it's using exclusively conservative variables? Are the printed norms before or after conversion? I think we decided to report the...

Hmm, the conversion doesn't seem to be right! They did make sense to me when I was running experiments for the course project (although I wasn't running them with the...

This is rebased now but when I try to reproduce [these runs](https://github.com/CEED/libCEED/pull/1109#issuecomment-1373950726), I see a segmentation violation. Same issue exists on `main` as well. I'm investigating. Also, what sort of...

> Probably the issue just fixed by #1179. Yep! That issue is fixed but all the blasius tests and "turb_spanstats" are failing now. I haven't been following the developments in...

The tests wouldn't fail until I rebased the branch onto main. It is so confusing 🤷🏼‍♀️ . I will try to look into it more closely today.

Alright, I think this approach is working now! I am trying to perform a convergence study but a quick test shows that at least the conversion is correct: ``` $...

Thanks, I added comments for `q_true` and changed the names. I am happy with a squash-merge if this last bit looks good to you.

> Can we have one test of this functionality? Do you mean a convergence plot?