Layla Ghaffari
Layla Ghaffari
Thank you, @pazner , for taking the time to examine the mesh and share the code snippet. I tried it, but unfortunately, it didn't work. > (Note: since you mentioned...
I'm still uncertain if this approach is valid, but I proceeded to code it as follows and ran Palace with the mesh file I provided earlier. ```cpp // Get coordinates...
It turns out the issue was indeed in the way I was retrieving the coordinates from the data vectors. Despite the comment suggesting otherwise, I was treating it as row-major...
Hi again, I’ve been testing the implementation in Palace. That trick worked and now I’m trying to use `MakePeriodic` when the user provides a non-periodic mesh and specifies the desired...
I think this branch was working for our purposes in the course project but is broken for the Advection2D and Euler solvers. A quick fix would be to define a...
Oh, true! I was talking about Newtonian since that is the only solver that uses `NewtonianIdealGasContext`, IIRC. Then, I would prefer disabling the feature for Advection and Euler for now...
@jedbrown , does this look good to you now?
@jedbrown , can we merge this branch if there are no other concerns?
Here is the output with the traveling vortex problem: ``` $ build/fluids-navierstokes -problem euler_vortex -degree 2 -q_extra 2 -dm_plex_box_faces 5,5,1 -dm_plex_box_lower 0,0,0 -dm_plex_box_upper 125,125,250 -dm_plex_dim 3 -mean_velocity 1.4,-2.,0 -bc_inflow 4,6...
> Why does it always say `Conservative variables` (regardless of `-state_var primitive`) ? It's because traveling vortex doesn't support primitive variables yet.