Lavinia Popa-Rössel
Lavinia Popa-Rössel
> @lavipr Looks good at a first look. But new schema update SQL scripts (name e.g. `4.0.0-2019-07-02.sql`) below folder `administrator/components/com_admin/sql/updates` are missing for the database changes in joomla.sql. Will you...
> @lavipr I can make a PR for the schema updates against your branch, which you then can merge so it goes into this PR. Is that ok for you?...
@brianteeman Thank you for your code review and your test. @SharkyKZ Thank you too.
> @lavipr Before I make any schema update: Why did you use data type `text` for the `master_date` column? I would have expected `date` for MySQL and `timestamp without time...
> Eager to test, but atm just a question: is it necessary to define the master/reference language in the language filter plugin, instead of com_associations Options? @infograf768 The idea was...
> @lavipr Ok, I'll wait with the schema updates. Ping me here when ready. Could you please have a look to my database changes: 5c321cb ? Thanks!
> @lavipr Data type in database looks ok now. I will make the PR for the schema updates in a minute or two. But still in PHP you use string...
> @lavipr Hmm, just right now I have finished the update sqls, see [lavipr#6](https://github.com/lavipr/joomla-cms/pull/6) Ah I forgot to add the new files to git... So I merged your PR. Thank...
> thank you for this big enhancement..and if you need any help on prepared statements, don't hesitate to ping me @alikon In fact, I would need help with the prepared...