laura

I think there is a simpler overall approach to this problem that involves creating a oneshot channel and passing it to any tokio task that is spawned, and if we...

The [ invariants for liveness document](https://www.notion.so/mystenlabs/Ensuring-Narwhal-Liveness-After-Large-Scale-Recovery-329b6d606fd746e9a974594435175c93) goes over the approach to maintaining liveness, which is a rather delicate 3 part solution, each which inter-depends on the other. t looks like...

ready for re-review

> Also, I second @tzakian's question on whether it's feasible to add something to ensure `sui-node` is never built with the profiler enabled. Yes, I added a warning if it...

> The main question I have is for the Cargo.toml files I see a number of places where the fatures are both manually set for the crate being imported and...

@amnn The best way to convince yourself that it works is to try it None of this is well documented, and took weeks of trial and error `cargo install --locked...

I have made the fixes and added a test. @amnn thank you so much for those finds! There was one un-resolved comment thread about the fact that I removed the...

The removal of the gating of the trait function members get_profiler and set_profiler will not cause any performance regression because all calls to these two functions remain gated. The profiler...

> I haven't been apart of the discussions on profiling but I'm very hesitant about the path that is being taken here wrt using cargo feature flags. Feature flags tend...

I have removed the feature addition to the CLI build as we agreed above, and started a thread in the PE channel for setup of a different task to run...