Giles Lavelle
Giles Lavelle
Okay, I'll try and get some simple benchmarks for append and truncate done before I begin on the HTML5 FS performance improvements. I'll make a wiki page for benchmarks.
Made [a start](https://github.com/lavelle/BrowserFS/tree/benchmark).
[Wiki page](https://github.com/jvilk/BrowserFS/wiki/Performance).
Yeah, I agree that benchmarks and unit tests should be separate, I've already done that. Don't see why we can't use Karma for both though, since it's already installed and...
I'd much rather stick with Karma's approach and have all input and output on the command line - tabbing to a browser and using a GUI is just going to...
Okay, well the vast bulk of the work (writing the benchmarks themselves) will be reusable. It's only a few lines of code being thrown away if you don't use Karma...
This is ready for review, though I still need to figure out how to get react-docgen to show the full list of props even when using `extends` on the interface
Would also be good to add the `event` argument to the `onBlur` and `onFocus` methods of these components, as we do for others like `TextArea` and `Dropdown`
Original Slack Thread (TT employees only) https://thumbtack.slack.com/archives/C0GKYQVTR/p1603911530021700