Grey Moore

Results 7 comments of Grey Moore

I think this is a version dependency issue. We started seeing this error when we upgraded the `redis` gem from 3.3.5 to 4.0.1. Rolling `redis` back to 3.3.5 fixed the...

> Re: Style/RedundantCurrentDirectoryInPath > > I prefer consistency. It is pretty weird to me that rubocop's default for `rescue` is to be explicit, while for `require_relative` it's implicit. Let's just...

> On a side note about this PR, I think I made a bad decision back when I started this gem on providing custom `sidekiq_throttle` singleton class message, probably we...

Hmm, I've been working on getting the `sidekiq_class_attribute` approach to work, and as far as I can tell from my testing, if we do this in `Sidekiq::Throttled::Job`: ```ruby def self.included(worker)...

So maybe we invoke `sidekiq_class_attribute` for the inheritance benefits, but instead of users using sidekiq_throttled_requeue_with in the class directly, we keep the `requeue_with` option for `sidekiq_throttle`? That also avoids any...

Okay! I've made a number of changes. The basic usage should now look like this: ```ruby sidekiq_throttle threshold: {limit: 123, period: 1.hour}, requeue: {to: :other_queue, with: :schedule} ``` with support...

Adding content type spoofing validation sounds like a good idea to me too. I think `kt-paperclip` has a feature like this: https://github.com/kreeti/kt-paperclip?tab=readme-ov-file#security-validations