Bogdan Kanivets

server: don't panic in readonly serializable txn

4

Problem: We pass grpc context down to applier in readonly serializable txn. This context can be cancelled for example due to timeout. This will trigger panic. Solution: provide different error...

Revision in response header might not reflect data in the body

2

### What happened? Related to https://github.com/etcd-io/etcd/pull/13940 In LeaseLeases function, newHeader is called at the end and there is no synchronization. https://github.com/etcd-io/etcd/blob/main/server/etcdserver/v3_server.go#L399 This can cause a situation when list of leases...

[3.5] server: don't panic in readonly serializable txn

1

Problem: We pass grpc context down to applier in readonly serializable txn. This context can be cancelled for example due to timeout. This will trigger panic inside applyTxn Solution: Only...

functional: remove SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT command

6

Problem: both SIGQUIT_ETCD_AND_REMOVE_DATA_AND_STOP_AGENT and test.sh will attempt to stop agents and remove directories. Solution: since test.sh creates directories and starts test, it should be responsible for cleanup. See https://github.com/etcd-io/etcd/issues/14384 Signed-off-by:...

server: removed 'experimental' from warning-unary-request-duration flag

3

fixes https://github.com/etcd-io/etcd/issues/13783 Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

draft: reproduce root cause of flaky ExampleCluster_memberAddAsLearner

4

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[test] after failure functional tests can't access logs in /tmp/etcd-functional*

1

### What happened? In case of functional test failure, test.sh can't access etcd logs. /tmp/etcd-functional* dirs are already removed > PASSES='functional' ./scripts/test.sh --- FAIL: TestFunctional (16.32s) --- FAIL: TestFunctional/round:0 (1.24s)...

[WIP] *: support online downgrade from 3.5 to 3.4

6

Tested this by running 3.5 binary with benchmark (to generate load): ``` bin/etcd --name infra1 --listen-client-urls http://127.0.0.1:2379 --advertise-client-urls http://127.0.0.1:2379 --listen-peer-urls http://127.0.0.1:12380 --initial-advertise-peer-urls http://127.0.0.1:12380 --initial-cluster-token etcd-cluster-1 --initial-cluster 'infra1=http://127.0.0.1:12380,infra2=http://127.0.0.1:22380,infra3=http://127.0.0.1:32380' --initial-cluster-state new --enable-pprof...

server: add fields to migrate from 3.5 to 3.4

14

Tested migrate from 3.5 to 3.4 manually. ``` $ ./bin/etcdutl migrate --data-dir --target-version 3.4 2023-06-01T10:47:51-07:00 info schema/migration.go:65 updated storage version {"new-storage-version": "3.4.0"} $ bbolt get /member/snap/db meta confState key not...

stepWait not used in ProposeConfChange

1

`stepWait` was [implemented](https://github.com/etcd-io/etcd/pull/9137) to fail-fast in [Propose](https://github.com/etcd-io/raft/blob/main/node.go#L444) method. But it was never used in [ProposeConfChange](https://github.com/etcd-io/raft/blob/main/node.go#L469) method. [Question](https://github.com/etcd-io/etcd/pull/9137#issuecomment-474218191) was raised about it on original PR. Also, it's was causing timeout in...