Bogdan Kanivets

Results 71 comments of Bogdan Kanivets

Feel free to start a new PR, we can close this one. The goal was to showcase the idea.

Sorry, the use case isn't clear to me. Can you link apiserver code that will use this new flag?

@ahrtr > The client side sees a grpc error, not sure why. Maybe you need an [import](https://github.com/kubernetes/kubernetes/pull/124787/files#diff-fecbb81ea44aa990e282819619fd05a2ce5023c9360bc1db1174d723beef6237R59) that sets `internal.HealthCheckFunc` Any danger to roll this out enabled by default? Do...

> Please anyone feel free to continue to work on this task on top of this PR assigned to myself

@ahrtr, yes, will try to find time this week. Please assign to me.

I'm focusing on reproducing interleaving transactions with default go client. We have 3 possibilities for retry: 1. [isContextError](https://github.com/etcd-io/etcd/blob/c79c7d5440f53600836f9d1d69441ef5541f719a/client/v3/retry_interceptor.go#L72) check 2. [shouldRefreshToken](https://github.com/etcd-io/etcd/blob/c79c7d5440f53600836f9d1d69441ef5541f719a/client/v3/retry_interceptor.go#L80) check 3. [isSafeRetry](https://github.com/etcd-io/etcd/blob/c79c7d5440f53600836f9d1d69441ef5541f719a/client/v3/retry_interceptor.go#L92) check We'll ignore 2 for now...

Is this for Kubernetes use case or general case? FYI, Kubernetes recently [added](https://github.com/kubernetes/apiserver/commit/f4edb394b0e83de067176cccc2fbefea217632a8) `maxLimit = 10000`

@vorburger sorry about slow reply. I'll try to rebase, give me some time

Sorry, I got busy and didn't followup last year back when it was still fresh on my mind. @jcferretti your PR looks good, but imo it will be better to...