Laurent Savaete

Results 227 comments of Laurent Savaete

@roblevy I had the same issue, and using the `finish` bisection recommended in the [README](https://github.com/mxw/vim-jsx#troubleshooting) I found the culprit to be these lines in my `.vimrc` that set different indentation...

Hi @china-zhoujie can you share your code and the full error message you are seeing? Also please include the versions of Fastapi/starlette that you're using. It is impossible to help...

Hi @mallorbc sorry this was confusing. Is this link what you're after? https://limits.readthedocs.io/en/stable/quickstart.html#rate-limit-string-notation Let me know if this helps. We'll have to update the docs to include this, and maybe...

@mallorbc Did the above link solve your problem?

> @laurentS anything else you want to see here for this to be mergeable? @colin99d thanks for submitting this PR! I just took a quick look, but I saw the...

> @laurentS anything else you want to see before this is merged? @colin99d I merged @Rested 's suggestions, can you just check that tests pass, etc..., and I think we're...

Maybe we should try to do one thing per PR. Let's focus this one on the feature you initially proposed, and we can add `ruff` in a separate one. I...

> I reverted ruff changes. All tests fail because of this line: `self._exempt_when_takes_request = len(inspect.signature(self.exempt_when).parameters) == 1` It just needs reformatting. Can you run `black` on your code? I can't...

> @laurentS are we waiting on anything else here? I think CI checks should be green before merging :) Logs seem to have been removed by github, but I think...

> Can you please rerun them so I can see what it is? I can't seem to rerun CI on github, weird. I pulled your changes locally, try `poetry run...