Laurent Savaete

Results 227 comments of Laurent Savaete

Sounds good! Feel free to send a PR for this, or to add an example in the docs.

> Thanks, I will raise a PR. Could you please give me access to push a branch. I don't have access to the repo settings from mobile, but you can...

I've just added a number of people who had contributed PRs in the last few months.

@thearchitector thanks for opening this issue. I think it relates to #3 What you're suggesting makes complete sense in my mind, I initially wanted to make `slowapi` fully async, just...

@NotoriousRebel I'm going to try to do a first async version this week or next, with a Redis backend.

I've been able to reproduce the issue in a test, but haven't had time to put together a complete fix. I'm not far off, I'll try to finish it over...

@papapumpnz no, sorry. I haven't found time to work on this any further. It would probably help if you could provide a couple of test cases that reproduce the error(s)...

I should have updated this issue a while back. Does [this example](https://slowapi.readthedocs.io/en/latest/examples/) show what you want?

@himalacharya did you find a solution to your problem? can you share here, if it was related to slowapi?

My concern with your fix is that you seem to be mixing access control into rate-limiting, which could have security implications. In my mind, your access control layer should block...