Thomas Bracht Laumann Jespersen

Results 66 comments of Thomas Bracht Laumann Jespersen

@LPGhatguy It has not been fixed yet. If you read the discussion, I think we worked out what the correct fix should be, but it is potentially a rather big...

Hey @colin-kiegel, sorry for not getting back on this PR sooner. I'm somewhat hesitant to merge a change like this, because this tool is meant to just be an extraction...

On Sat, Dec 08, 2018 at 08:56:33PM -0800, Sunjay Varma wrote: > The Rust 2018 edition removes the need for `extern crate`, but I still find myself needing to add...

That doesn't look to bad to carry over (at a glance).

Hi, that looks a little odd, if I understand your CI setup correctly, you only use compiletest with nightly? Could it be that nightly has changed an we just haven't...

Looks like it's related to #162 (see [this comment](https://github.com/laumann/compiletest-rs/pull/162#issuecomment-474606769)).

@Manishearth Can't we just roll the libtest changes back? Why would that break the stable build?

Can you please explain why that is the fix? Was 0.3.19 broken prior to #162 being merged?

> No, rustc's libtest changed, we can't roll that back. Oh, I didn't read your comment closely enough, I think. How about a split down the middle, using `libtest` for...