Kasper Laudrup
Kasper Laudrup
> I'd have to take another look at it but I'd wager it's because those headers are included somewhere before wintls is included so it doesn't get the chance to...
Fixed in #85
Looks like how this should have been done initially. Thanks a lot. If you remove the ugly `#ifdef UNICODE` stuff I had written initially I think this could be merged....
Sorry, I had completely forgotten about this
Building C++ code on Windows is complicated and not really related to this project, so I'm afraid I cannot help you with this. I suggest you find some resources/forums related...
Sorry if I sounded a bit harsh, didn't mean to. This project should indeed support Windows/MSVC but it sounded like the issues you were facing were more related to building/linking...
> There are conflicting codes. But the code in mainline doesn't seem to pass CI. Do I need to wait for the mainline code to be fixed first? As far...
> Unit test works fine. But coverage and coverity task failed :( The coverage and coverity jobs require access tokens which are only available on my github repository. I assume...
Looks great. Only one minor comment left then I think should be ready to merge and I should probably also make a new release with this. Thanks a lot.
@windowsair Seems like I forgot to actually submit my final comment. After that I think we should merge this. Thanks.