lz4_stream icon indicating copy to clipboard operation
lz4_stream copied to clipboard

I'd love some instructions on how to build using VS2022 with a CMakeList console app

Open adamsd5 opened this issue 1 year ago • 3 comments

I'm new'ish to cmake, certainly so on Windows. But I have a VS2022 Cmake console app running. It is unclear to me how to setup the lz4 library (which I've downloaded and added the include/lib paths to my CMakeList.txt). Also, I've setup my git path and attempted to use set(LZ4_STREAM_UseBundledLz4 TRUE). However, I cannot get it to work.

I get an error about needing: lz4_stream/thirdparty/lz4/LibLz4-prefix/src/LibLz4/visual/VS2010/bin/_Debug/liblz4_static.lib

adamsd5 avatar May 06 '24 01:05 adamsd5

Building C++ code on Windows is complicated and not really related to this project, so I'm afraid I cannot help you with this.

I suggest you find some resources/forums related to C++ on Windows.

Good luck.

laudrup avatar May 13 '24 16:05 laudrup

Noted, and thanks. FWIW, you include "Windows (MS C++):" in the build targets. If you don't want to support it, that's understandable... maybe remove this? (I spent time on your project because I assumed you did support Windows/MSVCPP)

adamsd5 avatar May 14 '24 05:05 adamsd5

Sorry if I sounded a bit harsh, didn't mean to.

This project should indeed support Windows/MSVC but it sounded like the issues you were facing were more related to building/linking with libraries on Windows in general.

I haven't looked at this project in ages but hopefully it should be possible to figure out how to make it work by looking at the build pipeline. If you feel like something is missing or should be updated, a pull request would be very much appreciated.

Thanks.

laudrup avatar May 14 '24 08:05 laudrup