Anton Viktorov

looks like component always sends sms in text mode. I found an article in russian, second half explains how to send in PDU/UCS2 format. http://codius.ru/articles/GSM_%D0%BC%D0%BE%D0%B4%D1%83%D0%BB%D1%8C_SIM800L_%D1%87%D0%B0%D1%81%D1%82%D1%8C_3 I checked my sim800l -...

@mrtoy-me thanks for taking a look and testing 1. I don't believe its a good thing, it just a hack which works due to specific bit positions in the struct....

> LGTM -- thanks for working on this! Thanks. There are several more PRs to review! :)

Looks like this component might support more than 2 sensors. There is number of ALS sensors, PS(Proximity) sensors and ALS + PS integrated sensors from Lite-On which share same API,...

> It might be that this is an issue from my side, I'm not fully sure yet. I can do some more testing and comparing my code with this if...

+1. downloaded 3d model just to insert it to fusion assembly and make holder.... no screw holes... 👎 👎 👎

> Also, for consistency's sake, consider using the full Mac address (like the client ID does) instead of the last 3 bytes (the whole `get_mac_address()` function). This was done to...

Closing PR as 'against the design idea` for now.

> Some small (mostly grammar) corrections Thanks a lot for corrections. I made couple minor updates and its ready for review.

@kbx81 thanks for the updates