Florian Plattner

Results 9 comments of Florian Plattner

I was trying to imlement something like this and I thought having side-by-side images would be nice. So I used the `viuer` crate as suggested by nyurik. However i ran...

I think this is no longer relevant since `git log` is being used now. `git log --first-parent` has the desired behavior by default, so no need to pass `--diff-merges=first-parent`.

I've made some adjustments: As you suggested I've changed it so the contents are first written to a temporary file with the `.snap._` extension. At the start of the `assert_snapshot`...

> While we wait for a more informed review, one thought (not confident): I notice we add new enums — would there be any case for collapsing "Inline | Named"...

> (I note we're handling the contents differently between named string and named binary snapshots — string snapshots we hold the value in memory while binary snapshots we hold only...

Sorry for replying so late. > Yeah. And IIUC we are storing them in memory when writing them at the moment. (+ agree given they're in git, the likelihood of...

> Thanks for resolving the merge conflicts! That must have been a decent amount of work... > > One note — I've recently spent lots of time simplifying the internals,...

I ended up getting relatively far today. I currently have the new version at: https://github.com/lasernoises/insta/tree/in-memory-binary-snapshots. There's still some smaller stuff I need to take care of and then I'll probably...

I decided to open a new PR because the implementation is sufficiently different and it might be nice to be able to easily compare them.