Eric Larson

Results 673 comments of Eric Larson

> Extract in smaller PRs So far the PR is remarkably small, so hopefully we won't need this. Once the abstraction is done and @alexrockhill is happy with the interactions,...

... and the goal here is really to close mne-tools/mne-gui-addons#14, right? So far so good I think!

I just noticed you say so at the top. So never mind my question, go go @GuillaumeFavelier !

Can we pin to a version that works, preferably with `!=` for now? Then hopefully the next version they release doesn't have this problem. If it does, we add another...

I will review as you split it up -- @alexrockhill can you do the hands-on testing here to see how things work?

> Also automatic theme detection is not implemented yet either If it uses our abstraction it seems like you should get this for free, no? > I think this is...

@alexrockhill could you take over and finish?

@alexrockhill should we close this in favor of transitioning the existing GUI to your new framework? Do you see this as a lot of work?

I suspect that this an https://github.com/mne-tools/mne-python/issues/10991 are both to translucent geometry not working on VTK+Mesa 18.3.4. I assume you can't upgrade to CentOS 8 or something else with a newer...