Eric Larson

Results 673 comments of Eric Larson

Ultimately we need to have some unit tests, and ideally some example showing the functionality. Maybe we can use the `sample` dataset structural to fake it so we don't have...

FYI there is some progress being pushed here in https://github.com/openmeeg/openmeeg/pull/443 and https://github.com/conda-forge/openmeeg-feedstock/pull/18

... the TL;DR of those is basically that support will hopefully be added to MNE-Python in the next couple of months, starting with: 1. Just macOS + Linux via conda-forge...

Nice summary! I suggest that when you go to actually work on one of these (whichever you want first), start a new issue with any questions. If we try to...

> I just skimmed over the Matplotlib 3.3 changelog and it seems some of the new features could really help simplify some of our code. Unfortunately we can't rely on...

> Currently I can only assume that in MNE-Python, any neighboring relationship (2 timepoints, or 2 channels) makes up a cluster. Actually a single time point and single spatial location...

> it also controls the number of "observed" clusters. This is a pretty easy operation (almost/possibly a one-liner) to do on the observed clusters after the fact, though. So I'd...

> In the drawn scenario, this is 1 single big cluster that has a much larger extent simply because there are a few channel/time "bins" that extend like "fingers" from...

> Because we could tune my example such that it would result in a single cluster, ... and still look like something that I'd rather control to not be a...

Okay that makes sense. It seems doable in principle given our existing code. I think we can achieve minimums for: 1. Time points spanned by a single spatial node by...