Lars Hvam

structure of interface or class definitions

15

Hi, In CLASS or INTERFACE definitions, the DATA/METHOD definitions can be interleaved, personally I don't expect any TYPE/DATA/CONSTANTS etc definitions after METHODS definitions, but what is considered good practice? I...

use/definining of public ALIASES

6

Hi, Any thoughts on public ALIASES? Personally, I'm leaning towards it being bad in all cases, it's either another indirection or something wrong in the Object Oriented design.

`` not defined, ```abap DATA chain_tokens TYPE STANDARD TABLE OF string WITH DEFAULT KEY. *FIELD-SYMBOLS TYPE STANDARD TABLE. DATA sfrom TYPE i. APPEND LINES OF FROM sfrom TO chain_tokens. ```

https://rules.abaplint.org/many_parentheses/ ```abap LOOP AT tab_statements ASSIGNING WHERE ( type 'P' AND type 'S' AND type 'G' ) AND from

https://rules.abaplint.org/modify_only_own_db_tables/ `MODIFY pi_fieldcat FROM l_fcat.`

```abap TYPES: BEGIN OF albums_typee, artist_id TYPE string, END OF albums_typee. TYPES albums TYPE STANDARD TABLE OF albums_typee WITH KEY artist_id album_id. ``` and ```abap TYPES: BEGIN OF albums_typee, artist_id...

RAISNG part must be a subclass of cx static or dynamic

```abap CLASS lcl DEFINITION. PUBLIC SECTION. TYPES: BEGIN OF foo, field TYPE i, END OF foo. ENDCLASS. CLASS lcl IMPLEMENTATION. ENDCLASS. START-OF-SELECTION. DATA(ref) = NEW lcl( ). DATA(sdf) = VALUE...

refactor rule so it runs faster if there are no syntax problems in the code no need to check everything if there are no problems

https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-check-in-other-positions https://github.com/abapGit/abapGit/pull/5709