Lars Hvam

Diggy, feature request: Show XP earned in the player list

1

**Is your feature request related to a problem? Please describe the problem.** It would be fun to show the XP earned by player, stones mined counts up, deaths count down....

`cl_xml_document` is not Steampunk compatible, #632, https://abapedia.org/steampunk-2205-api/ and note its just a wrapper on top of `ixml` classes/methods this will also enable additional unit testing, https://github.com/abap2xlsx/abap2xlsx/pull/872

Removing unnessssary DDIC dependencies

16

Suggest replacing usages of the following types with builtin types like `C` and `abap_bool` ~~BOOLEAN~~ 9 ~~CHAR_02~~ 2 ~~CHAR01~~ 6 ~~CHAR07~~ 44 ~~CHAR08~~ 1 ~~CHAR1~~ 31 ~~CHAR10~~ 23 ~~CHAR2~~ 8...

Better Documentation

2

ref https://twitter.com/TudorRiscutia/status/1250704261576642560 + Introduction + Supported Features + UML diagram + ...

styleguide vs ABAP Programming guidelines

4

there is https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenabap_pgl.htm and other places in the ABAP help, which defines guidelines/recommendations Personally I think it would be nice to have everything in one place However, there is also...

CHECK vs RETURN, example

7

in https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return the good example ```abap METHOD read_customizing. IF keys IS NOT INITIAL. " do whatever needs doing ENDIF. ENDMETHOD. ``` Might not be super good, especially it introduces nesting,...

Don't declare inline in optional branches

2

https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-declare-inline-in-optional-branches In this example a variable is declared in an optional branch, ```abap IF foo = bar. LOOP AT tab INTO DATA(sdf). ENDLOOP. ENDLOOP. ``` according to the rule description,...

formatting: empty lines inside statement

1

The formatting chapter, https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#formatting, has good recommendations on when to break lines, but it can also be too much. I suggest adding a recommendation not to break lines inside the...

SELECT SINGLE, vs SELECT ENDSELECT, vs SELECT UP TO 1 ROWS ENDSELECT

18

What would be the preferred way of selecting a row from the database? SELECT SINGLE, vs SELECT ENDSELECT, vs SELECT UP TO 1 ROWS ENDSELECT Personally I use SELECT SINGLE...