larryonoff

Results 42 comments of larryonoff

I think the current version of VideoPlayer is very limited. There're number of features that are needed for: 1. play / pause 2. overlay for video rect

@kean please check my PR https://github.com/kean/NukeUI/pull/21. I started doing some work in this direction.

Just tried `performBatchUpdates` branch and it didn't help.

I think that `Dwifft` should have method ` func setSectionedValues(_ values: ..., animated: Bool)`. This will help people using the library in case of having the same issue. I'm having...

I also think that `performBatchUpdates` is reasonable to merge into `master`. It just uses new iOS 11 functionality.

I completely agree that all changes must be reasonable. But I think there’re be cases when we don’t need any animations to update table view / collection view, like the...

@intoxicated it looks that solutions is easy, but hacky. Try doing the following after settings `sectionedValues` ```tableView.layer.removeAllAnimations()```

@danya61 I don't use Dwifft anymore. I switched to DifferenceKit

@danya61 hmmmm. I don't remember that I've faced with the current issue. But this not 100%

It maybe reasonable implementing a `diffable.diffIdentifier` similar like IGListKit. So the library is able to understand that it's the same object, but needs reload.