Nicholas La Roux
Nicholas La Roux
@frankietyng, okay, please let me know if the partner will be opening a pull request by Monday. If they cannot, we can probably spin something up. Need to find SVGs...
AliPay HK icon was merged and made live a week or two ago. Leaving this open as we've yet to add Octopus.
> Currently we dont have a pure svg version of this icon. I can see other icon files also have base64 contained svg. And our file size is only 106...
> Curious, why standardize by removing all underscores rather than enforcing their usage in a consistent manner? Would make things much easier to read. Though you might be prioritizing simplicity...
👋 Hello, apologies but I (personally) no longer maintain this gem. If this icon is for use within Shopify you may be able to reach out to your partner manager...
👋 Hey @maunaw, we will try to take a look soon. Thanks for the PR. :)
Looks like we have some failing tests. (example failure below) ``` {:message=>"The 'pagoexpress' SVG file should have a 'viewBox' attribute on the root tag"} ```
👋 Hey @yanikleiman, I'm sorry to inform you that we aren't accepting new icons unless they're part of the new Payments platform, which is still rolling out. You can read...
👋 Hello @zeo-rap, thank you for your contribution. Just wanted to let you know there's a failing test. ([CI log](https://github.com/activemerchant/payment_icons/pull/461/checks?check_run_id=2846128255)) ``` Failure: PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [/home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:99]: {:message=>"The 'octopus' SVG file should have...
👋 Hey @zeo-rap, can we update the icon according to these [guidelines](https://github.com/activemerchant/payment_icons/blob/45da15340037403d0061cf1712125fa22d3713ef/CONTRIBUTING.md#guidelines-for-new-icons)? For example should have white background instead of transparent.