payment_icons
payment_icons copied to clipboard
adding octopus icon
** Checklist **
- [x] All icons have a corresponding entry in
db/payment_icons.yml
- [x] I have followed the icon guidelines detailed in the CONTRIBUTING.md file
- [x] I have optimized the icon with SVGO
- [x] I am confident that all icons are clear and easy to read/understand
- [ ] I have provided a link to the brand icon’s brand guidelines whenever possible.
If this pull request is not adding new icons, you can remove this checklist.
👋 Hello @zeo-rap, thank you for your contribution. Just wanted to let you know there's a failing test. (CI log)
Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [/home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:99]:
{:message=>"The 'octopus' SVG file should have a 'aria-labelledby' attribute on the root <svg> node"}
👋 Hey @zeo-rap, can we update the icon according to these guidelines? For example should have white background instead of transparent.
Closing the PR because it has been stale for a while. If the change is still relevant, please re-create the pull request using the new pull request template. We are sorry for the inconvenience.