Sergey Larionov
Sergey Larionov
@siddharthkp I agree that functional tests are needed but just now I had a problem when empty css files was generated in our package. That requires automated visual tests and...
On Mon, Apr 2, 2018, 19:49 Siddharth Kshetrapal wrote: > bundlesize and maxSize names kind of imply that this package checks > everything about sizes > > I didn't try...
Ok, that's unfortunate. Thank you!
We went with `magic-importer`: `bili.config.js` ```js import path from 'path'; import magicImporter from 'node-sass-magic-importer'; const config = { plugins: { vue: { style: { preprocessOptions: { scss: { importer: magicImporter(),...
To check for the changes made without pushing to repository. No need to write the image data to s3 in that case.
I tried that and to fetch the images the s3 command requires s3 credentials, which I don't have. But the image data is available on s3 publicly
I would prefer not to have to do that because then every team member will have to go and get them, and that's not an easy process.
Do you think making a publish plug-in that works with git instead of s3 is a good idea? One drawback I see is it's harder to publish the report
Also found out that using git hash + s3 as source for the screenshots to compare to can be unreliable if the parent branch fails the build. Now it doesn't...
There is the same functionality in Google Photos and I find it quite useful