Allon Moritz comments

Results 343 comments of


                                            Allon Moritz

Select-Button and -Text need more Contrast

@ciar4n is this a template issue or specific to MM?

IE11 has problems with JS

Is the promise issue because of #561?

Size of image in modal view

What would help is a screenshot, if available.

Change structure of create folder model.

The system test fails. Like that it can't be merged as it will cause problems when merging into upstream. @rdeutz how should the tests being adapted?

Resize workflow

For what for a use case do you need the thumbs? Actually we are in a debate on the Glip channel about how to implement source sets in images.

Resize workflow

Guess that can be solved with pagination and not floating the disc. When a cloud adapter is supporting a thumb property, then the MM JS client is using that one...

Resize workflow

The hooks are there now for 3rd party extensions with an example in the resize plugin to have max dimension after upload, but I would not ad a thumbnail functionality...

Use of JS Promise för aply and save in image edit view + some modal messages + a modal progress

Thanks for that. Gave it the JS gurus for review.

Use of JS Promise för aply and save in image edit view + some modal messages + a modal progress

I like the idea of a progress bar, especially as editing now also works with cloud adapters, the upload can take longer.

Use of JS Promise för aply and save in image edit view + some modal messages + a modal progress

You can do `node build.js --compilejs media/com_media/js/edit-images.js` to compile it.