Zach Langford
Zach Langford
Is there a reason all the function parameters are strictly typed to `Float64`? This causes issues when using auto-diff tools (which need a more general type: `T
It might be interesting to use something like [`NamedDims.jl`](https://github.com/invenia/NamedDims.jl) or [`DimensionalData.jl`](https://github.com/rafaqz/DimensionalData.jl) for user-facing arrays. For example, accessing the derivative arrays.
The function `initialize!` resets the given `State` with respect to an `InitialConditions`. However, the `State.t` is not updated, which needs to be fixed.
#84 allows for circular orbit initial conditions, but we still need to implement the proper gradient computations.
It might be nice to integrate [Unitful.jl]( https://github.com/PainterQubits/Unitful.jl)/[UnitfulAstro.jl](https://github.com/JuliaAstro/UnitfulAstro.jl) into the code. Not sure what the performance difference would be. Maybe there's a way to have units optional?
Right now, specifiying initial conditions requires the user to enter everything as a float. I.e., this is not allowed: `b = Elements(m=9e-5, P=10)`, but this is: `b = Elements(m=9e-5, P=10.0)`....
The arrays of derivatives computed by NBG are ordered differently than the initial conditions. Namely, the masses come after the coordinates in the derivative arrays, but before the coordinates in...
Right now this fails ```julia a = Elements(m=1.0) b = Elements(m=9e-5, P=1000.0) ic = ElementsIC(0.0, 2, a, b) s = State(ic) ``` All non-specified orbital elements are set to 0....
Currently, the `Derivatives` structure is only used in intermediate derivative computations -- not to hold the final derivatives. It is also not exported in the module. A user wanting do...
We should make some basic plotting functionality such as plotting TTVs or displaying positions/orbital elements over time. To get started: - [ ] Write a function to compute TTVs from...