Marc Lanctot
Marc Lanctot
Hi @jthemphill, Thanks for the effort you put into this. Unfortunately with withering resources dedicated to maintenance, it is unrealistic that we will be able to import this, so I...
Thanks for the PR! A few big things to do first. Basically, your contribution should be more consistent with the rest of the OpenSpiel code. 1. Google Python style. Please...
Thanks for the quick response. I added a few more comments. After your next commit, could you go back to the PR and resolve any comments that were done and/or...
@rhstephens This looks awesome!! Just chiming in quickly to say sorry for the delay in response. I was on holiday and have been catching up a putting out a few...
Meanwhile, could I ask that you pull changes from master and push the merge commit? We needed to fix a few things to get Github Actions CI working, so you...
A few minor comments for now (I may add more), but on the first glance the code looks very nice. Well done!
This was a year-long effort but with the help from many people, we were able to get permissions to include this game into OpenSpiel! Thank you @rhstephens for your patience...
Wow.. thanks! This is great. It might be a bit hard to merge right away due to reasons listed in https://github.com/google-deepmind/open_spiel/issues/770 But, we recently had a success story with Hive...
Looked a bit into the publisher.. Asmodee is listed. This could be good news. Hanabi was one we previously got permissions for and it's also published by Asmodee. So it's...
Please revert `install.sh` as the new abseil still causes some tests to fail on Github CI. (I will try to find time to fix that properly in master-- next week...