Marc Lanctot
Marc Lanctot
Hi @VitamintK, just checking: did you ever submit a fix for this?
Hi @VitamintK, Just curious if you still have that code lying around and if you'd still be up for providing a PR fix for this, or if you'd even be...
The failed wheels test is our fault from an update yesterday, we'll fix that. Apologies.
> The failed wheels test is our fault from an update yesterday, we'll fix that. Apologies. Ok, fixed. You can pull from master to get the changes, and your next...
> @lanctot: If you agree with the direction I've taken here, I think this is ready for another CI run. If you disagree and don't want a shared library here,...
BTW so far it's looking like that wouldn't be the case, so I'm not worried! But I just have to make sure before we import it.
I started the test from the last commit but.. yeah, just as I suspected, they are now failing because of a JAX compatibility issue. I suspect what happened was that...
Closed on purpose? (The issues with the jax tests were fixed last week.) Did I forget to press the button? Apologies, I've been busy fixing something else for an impending...
> Yeah, I was clearing my PR queue, and based on your last comment I just wasn't sure if you want to go forward with this PR in this form....