Lam Wei Li

Results 136 comments of Lam Wei Li

In https://github.com/log4js-node/log4js-node/pull/1269/commits/e7ea4039ab541b8b0b8a3724625157738e4d6ac7, https://github.com/log4js-node/log4js-node/pull/1269/commits/deca3fbc1b8b69a58828122bf0dd57e9be984d39 and https://github.com/log4js-node/log4js-node/pull/1269/commits/b4e8a2790d374ca921a31e4eadaf1ca2cccb0a04, it is hard to identify and review the surgical changes. Those style/lint fixes in those three commits cloud the changes and will also bear the...

Hi @ZachHaber, I merged your PR https://github.com/log4js-node/log4js-node/pull/1271 that addressed the prettier. You can rebase and do a force push to this same branch to update the commits for this PR....

@ZachHaber Hi there! My apologies that I haven't been available to take a look at this yet. I'm not exactly sure about the current behaviour to be in a position...

I'm unable to run your codes at all. Can you provide a more complete snippet?

The following works. ```javascript const log4js = require('log4js'); log4js.configure({ appenders: { 'out': { type: 'stdout' }, 'everything': { type: 'dateFile', filename: 'all-the-logs.log', pattern: 'yyyy-MM-dd-hhmmss', keepFileExt: true, numBackups: 5 // total...

> UPD3: if I make simple pattern without any numBackups or backups properties – it keeps just 1 log :( > > ``` > tracefile: { layout, type: 'dateFile', filename:...

Noted, I will mark this as invalid as per the original issue.

> _Originally posted by @konser80 in https://github.com/log4js-node/log4js-node/issues/1171#issuecomment-1022378915_ > I use folders for old logs. And numBackups doesn't work then. It's not a problem for me - cause I save logs...