Lam Wei Li
Lam Wei Li
> The path is `/status-monitor` unless you have changed it. Pretty sure it's `/status` according to the codes and [readme](https://github.com/RafalWilinski/express-status-monitor/blob/master/README.md). https://github.com/RafalWilinski/express-status-monitor/blob/8ff29e7c4a98e2adffa27689b3b80b2f33ea8b0f/src/helpers/default-config.js#L4
Try the following using `express-status-monitor@^1.3.4`? ```javascript const server = require('http').createServer(app); server.listen('3113', () => { console.log('server started'); }); const io = require('socket.io')(server); app.use(require('express-status-monitor')({ websocket: io, })); ``` Alternatively, you don't need...
Mostly closed in the 1.3.4 release (https://github.com/RafalWilinski/express-status-monitor/commit/be7b8fcfc6d24a45fee9c0c815ec2636ee621cfb). --- Nevertheless, there is 1 outstanding security vulnerability, https://github.com/advisories/GHSA-j4f2-536g-r55m. `[email protected]` > `[email protected]` > **`[email protected]`** This has been committed as https://github.com/RafalWilinski/express-status-monitor/commit/1a38ae56dfdb1808aa68ce196db008b28efce49f (or PR #188),...
I don't think there is a commit for `[email protected]`. I'm using `[email protected]` which upgraded to `[email protected]` with no issues.
This is closed with the 1.3.4 release (https://github.com/RafalWilinski/express-status-monitor/commit/be7b8fcfc6d24a45fee9c0c815ec2636ee621cfb) as they have upgraded `[email protected]` to `[email protected]` --- Nevertheless, there is 1 outstanding security vulnerability, https://github.com/advisories/GHSA-j4f2-536g-r55m. `[email protected]` > `[email protected]` > **`[email protected]`** This...
Superseded by #188.
For background information regarding `res._header` and `res.headersSent` equivalence: https://github.com/nodejs/node/blob/93e0bf9abf350637d772bcce14a5d9527b733300/lib/_http_outgoing.js#L741-L746 We can also add test cases to assert the equivalence (if really required). The code snippet is available @ https://github.com/expressjs/session/pull/908/commits/35880d6509e6ee6484521f746f936f8a56503be5.
@Icehunter, you might want to correct the indentations at line 740-744 and line 747-753. I didn't include them previously so that https://github.com/expressjs/compression/pull/170/commits/38fe9fd5756f524e438c9abb9e91e7193921e0e3 is surgical. https://github.com/expressjs/compression/blob/38fe9fd5756f524e438c9abb9e91e7193921e0e3/test/compression.js#L737-L756
@Icehunter, for the clarity that #129 is not in this PR, the description should change: > updated PR with rebase from express/compress:master to handle #128 ~~and #129~~
@dougwilson When you are free, can you review this PR? Fixes #122 and supersedes #128. Many thanks! 🤗 I didn't have access in the [forked repository](https://github.com/Icehunter/compression/tree/bugfix/use_writeHead_instead_of_implicitHeader) to run the GH...