Lam Wei Li

Results 170 comments of Lam Wei Li

Given the date of this issue, it should be `supertest@

@dougwilson, have you got the time to take a look at this PR?

Ok, I have split the initial commit (d021958) into two separate commits (92d05cc, df7163e) for clarity. 1. 92d05cc - added test case which fails if `res._implicitHeader()` is used (e.g. in...

I'm not sure if this change will provide full http2 support. IMHO, changing from an undocumented API to a documented API is a move in the right direction. As a...

Yup, agreed. For clarity, PR only fixes **ONE** undocumented API to documented API, which is `res._implicitHeader()`. 🤗

~~Ah, I don't seem to find any `res._header`.~~ ~~I guess we got lucky?~~ Ah, my bad, I found it. Bad search I had previously. I will address the `res._header` as...

Sure, thanks! While I have your attention, can you also kindly review https://github.com/expressjs/compression/pull/170? (I will delete this comment thereafter, just needed the GitHub to notify you.)

Continuation of https://github.com/expressjs/session/pull/908#issuecomment-1203407814: 4. 35880d6 - added tests to check for `res._header` and `res.headersSent` equivalence Strangely, while [`res.headersSent` is only available from Node.js v0.9.4](https://nodejs.org/api/http.html#responseheaderssent), all test cases (including the added...

@dougwilson, have you got the time to take a look at this PR?

Closed due to extended period of inactivity.