Andrew Lamkin

Results 26 comments of Andrew Lamkin

> Actually, it looks like you did not rerun tapenade after changing BCdata. Can you fix the issue? See [here](https://dev.azure.com/mdolab/Public/_build/results?buildId=5143&view=logs&jobId=d2df832b-d9a0-5ef5-bfcf-f856f4be5e1e&j=d2df832b-d9a0-5ef5-bfcf-f856f4be5e1e&t=d19c0cd3-a83f-5c03-1ec3-bf68c212ffee) Doing this now and re-running tests. Should be ready soon.

Also, this PR is adressing two separate bugs and I wonder if it should be split into two PR's? @eirikurj @sabet @anilyil do you have thoughts on this?

@anilyil I realized the `cpmin` cost function is only computed properly if the option `computecavitation` is set to `True`. There might be times when you only want `cpmin` and it...

> I think I addressed all of your individual comments @sseraj. I will look into adding the hole cutting test. > > @lamkina, how do you suggest we approach this?...

@gawng I think this effort is currently stalled and I don't think there's a timeline on anyone continuing this effort at the moment. I think it's best to leave this...

Closing this PR due to inactivity. I will shortly make a PR to address the multi BC issue and link it to this PR. There is an issue open (#353...

I think the MPhys tests that live in the ADflow repo should only test the parts of MPhys that interact with ADflow/MACH. The discipline coupling tests can exist in the...

I would check out the main branch and run the tutorial wing case. Print the initial state vector before ADflow runs the first analysis and you'll see it's an array...

Huh, I was not seeing this behavior in my initial testing. It's concerning that ADflow is overwriting a state vector internally that should be coming from OpenMDAO. This isn't happening...