Fixed multiple BC DV and setRotationRate rate for local blocks

[shubham135sd]

Purpose

Currently when multiple BC DVs of the same type are applied (e.g. bcinflowsubsonic, bcoutflowsubsonic), the second instance of the BC and its derivatives are overwritten on to the first BC and the values of the second BC remain unchanged and its derivatives are zero. The current PR fixes both the BC value change and its derivative update, which are manually differentiated routines.

Fixes setRotationRate(rotCenter, rotRate, cgnsBlocks=None). Currently when cgnsBlocks are passed, adflow adds rotation rate to 'n' cgnsBlocks starting from the first block number instead of applying the rotation rate to the specified block ids. The changes in this PR fix this bug.

Expected time until merged

One week

Type of change

• [ ] Bugfix (non-breaking change which fixes an issue)

Testing

Proper test case to be created.

Checklist

• [ ] I have run unit and regression tests which pass locally with my changes
• [x] I have tested locally that my fix is effective or that my feature works

[codecov[bot]]

Codecov Report

Merging #323 (bee9bd1) into main (559a1de) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   41.94%   41.96%   +0.01%     
==========================================
  Files          13       13              
  Lines        4005     4006       +1     
==========================================
+ Hits         1680     1681       +1     
  Misses       2325     2325              

Files	Coverage Δ
adflow/pyADflow.py	68.95% <100.00%> (+0.01%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lamkina]

Also, this PR is adressing two separate bugs and I wonder if it should be split into two PR's? @eirikurj @sabet @anilyil do you have thoughts on this?

[eirikurj]

I would prefer two separate PRs.

[lamkina]

Closing this PR due to inactivity. I will shortly make a PR to address the multi BC issue and link it to this PR. There is an issue open (#353 ) that addresses the other aspect of the PR.