Alexander Ponomarev
Alexander Ponomarev
@afiskon I will have a look soon
@afiskon what I understood so far is that for some reason with `cmake -G Ninja ..` it generates `build.ninja` with incompatible paths for static libraries. So in the build file...
@dermojo as I understand after your fix, the values will be copied anyway but during the function call, as it is not reference anymore but value. So you first pass...
@dermojo, In my view, the interface now looks complicated. User doesn't know that move happens internally unless he looks into the code. Can we implement a separate method for rvalues...
Moreover, a big problem is that for those who already use this library an update will cause additional move constructor involved. If you leave the PR as it is.
I agree with you that something should be done in this direction. Currently the only way if your class is heavy-weight is smart pointers. So it should be done. But...
Sorry, there is not benchmark.
@knedlsepp the library is not thread safe, you should use locking mechanisms to use it in a multi-threaded environment. Probably it should be better documented.
Also show this version in help
Maybe version should be encoded into the filepath projection, thus it will automatically invalidate the cache