Anna Kapuścińska

@sadath-12 Could you split the changes into logical commits? As there are five different fixes, it would make sense to have five separate commits for them in this case.

> Ya I can separate the commits like 1,2,3,4 . if after review I get changed related to 2nd commit how I make a new change and squash it under...

@sadath-12 I see the CI is failing because of a commit message being too long: https://github.com/cilium/tetragon/actions/runs/8004683889/job/21862554217?pr=1950 Could you rephrase it to fit the characters limit?

Thanks @sadath-12 for the updates. The code changes look good now. I rewrote the commit messages to describe exactly which metrics changed and split some commits to not mix up...

The CI failure is a known issue: https://github.com/cilium/tetragon/issues/2010. I'm merging this PR.

I used [gomod](https://github.com/Helcaraxan/gomod) to check how Tetragon depends on cilium/cilium Go packages. Here we go: ```sh gomod graph --style cluster=full -p 'deps(github.com/cilium/tetragon/**, 1) inter rdeps(github.com/cilium/cilium/**, 1)' > tetragon-cilium.dot && dot...

@olsajiri Is this still a problem? Running a recent build of Tetragon I'm seeing `tetragon_data_events_total` metric.

I'm closing this issue as `tetragon_data_events_total` metrics seems to be exposed correctly. If there is still a problem with it then feel free to open another issue.

This might be fixed by #2345. Let's keep an eye on [Tetragon e2e tests](https://github.com/cilium/tetragon/actions/workflows/run-e2e-tests.yaml) for a couple of weeks, if it's stable then we can close the issue. UPDATE: It...

> ok, used that in new version I see you use `MustNewCustomCounter` but the collector is defined as a separate type, not using `NewCustomCollector`. It would be nice to have...