Laird

Results 22 comments of Laird

> Nice, good job! Briefly tested! Would be nice to get it together with #4195 into 1.8.27 :) SCeditor needs some love! Agreed, @Eldenroot - it's excellent work, and it...

> it worries me the possible plugin incompatibilities I agree that there are possible plugin incompatibilities, but I also suggest that, generally, each plugin is, for the most part, only...

Thanks for your response, @euantorano. I like the hook idea that you have, and I'll be interested to read your blog post. I'm curious though to know your reaction to...

Oh, a very current example of the variables causing problems is in #3926. To summarise the problem being discussed in that PR: In global.php, at the beginning of the request,...

> If `headerMessages` was then registered as a Twig global, it would be accessible everywhere, including when `header.twig` eventually gets rendered. So `editpost.php` could just edit the Twig global, so...

> BTW, 1.9 code base doesn't have moderation queue right now. We could add a `$headerMessages['mod_queue']` to match the needs. Good catch. Yes, that seems to be missing.

> Then in editpost you could just re-generate the content for `$headerMessages['mod_queue']`. However, if that content were generated at the _end_ of the request rather than at the _beginning_, then...

> With the way, that variable is currently used it would not be easy, but IMO it should become an associative array like this [explanation snipped --Laird] Nice! That seems...

> I'll start drafting some stuff explaining how it all ties together and what exactly Twig does then. I would find this helpful too, being new to Twig and the...

> there shouldn't be an issue with later code modifying these variables before the header gets parsed. I think it depends on what those variables are though. Consider again the...