Lai Jiangshan
Lai Jiangshan
@WeiZhang555 could you implement it please?
The pr was outdated since more subcommands were added. Is it possible to implement it based on the bash-completion feature of the github.com/urfave/cli. @YaoZengzeng
the related code was changed a little, could you check it again please?
Sure. unit test is going to be added. runv is still lack of various kinds of test. We are trying to add more.
the issue is being addressing in #633
it is better to change the protocol of the hyperstart and let the hyperstart mount the pesudo-filesystems on the directory specified by the user.
list(partial): watchHyperstart() WaitResponse.func1() watchVmConsole() qemu.qmpReceiver() newContainer.func1() -> libhyperstart.(*jsonBasedHyperstart).WaitProcess() streamCopy.func1/2/3/4 vm.WaitProcess.func2 qemu.(*QemuLogFile).Watch() hypervisor.(*Fanout).start.func1()
updated. It should be tested with 2.8 or newer qemu. (just use the official qemu). And daxblock branch of the hyperstart. And in /etc/hyper/config. Hypervisor=qemu # or # Hypervisor=libvirt StorageDriver=rawblock...
"EnableNvdimm" needs to be added to BootConfig. otherwise the PR breaks cases with the older qemus.