Jérôme Lafréchoux
Jérôme Lafréchoux
> For your use case, is there an issue with using load? There could be if load has side-effects, like instantiating, or even writing stuff to DB (which might be...
From a quick check, I don't think a space instead of a + is valid ISO8601, so I'd rather not merge this. The SO issue you link to seems to...
> `?start=2021-04-01T00:00:00+02:00` Does this fail validation? It doesn't have a space.
I just had a quick look. Random thoughts: - This adds a cast to each serialization/deserialization operation. Performance impact ? - Should the type be used only on deserialization or...
Thanks for the rework. I'm not comfortable with redefining Iterable type. ```py _T = typing.TypeVar("_T") IterableType = typing.Union[ typing.Type[typing.FrozenSet], typing.Type[typing.List], typing.Type[typing.Set], typing.Type[typing.Tuple], ] ``` Unfortunately, I can't investigate this right...
Looks like a doc issue, indeed. Looking at the implem, the comment is correct if no callable is passed, but if a serialization callable is passed and no deserialization callable...
Or since this is easily achieved in user code thanks to a base schema as shown above, we postpone this to marshmallow 4 as described in my last paragraph. Adding...
> I believe that is caused by `OrderedDict`. None of the `OrderedSet` instance attributes are ever accessed during `dump()`, only the `OrderedDict` `dump_fields`. Yes, this is exactly what I meant....
@deckar01 Nice. On the short run (marshmallow 3.x) we'll probably be keeping `set_class` if only for backwards compatibility. There seems to be consensus with this so we may go on...
By design, marshmallow doesn't do validation on serialization. See for instance #1127, #682.