Jérôme Lafréchoux

Results 373 comments of Jérôme Lafréchoux

Well, either each custom field repo adds the attribute function and the tests (and the apispec test dependency), assuming the author is willing to (he may not be using apispec...

We could add a custom_attribute_functions.py file that would bake a sort of init function that would conditionally (the condition being importability) call add_attribute_function to add the custom field2attributes function. And...

I didn't check the result but thanks for sharing already. I'd be tempted to use a list comprehension: ```py if isinstance(field, marshmallow_enum.EnumField): return {'type': 'string', 'enum': [m.value for m in...

I just published apispec 6.0.0 with support for `marshmallow.fields.Enum`. While this doesn't fix this issue, I guess users will be moving to `Enum` so this can probably be closed. Feel...

Recent CI issues are due to changes in openapi_spec_validator 0.5.x, which is a dependency of prance. Until prance releases a fix, we should pin openapi_spec_validator

Yes, I saw that issue. I should have linked to it. Thanks. Does this mean you're using the feature and you're :-1: about removing it? In practice the feature doesn't...

Hi. There is currently nothing in apispec to provide a link feature. If it works by writing the link manually in the docstring, that's fine. I can't look into it...

Thanks for reporting. Anyone willing to propose a PR for this? Thanks.

I see what you mean. This is more or less what I do in flask-smorest: https://github.com/marshmallow-code/flask-smorest/blob/ec4fbecc71686535a38f8642760bab390f0fdc44/flask_smorest/spec/__init__.py#L269-L302. The form ma.map_to_openapi_type(fields.Dict)(Custom) is not that terrible. Agreed it looks strange. If we came...

The more I think of it, the more I lean towards just removing the decorator form. Let's do that in 6.0.