lae

Results 125 comments of lae

That didn't really clarify anything... If you're saying to move each task into its own file, that sounds extreme. Most of those tasks are just simple wrappers around their respective...

does it make sense to use the same repository for it? i haven't been able to find any good examples of people retrofitting existing ansible roles into collections. This was...

Seems like this was introduced in 3.1.0? (https://github.com/netbox-community/netbox/issues/7619) So from my perspective this is one of those features that should be configurable by this role in order to get 3.1.0...

Oh I thought the custom validator support in 3.0 was just a specific DSL in `configuration.py`, not external files. I just thought of something I've done before that might be...

#190 is from my perspective a simpler feature because we're only copying a singular file there which NetBox seems to already be aware of. Anyway feel free to have a...

I'm kind of on the fence about it being a single file since it deviates from what Tyler and I discussed previously, so I'm postponing my review for it for...

A single file is okay. I don't personally use custom validators myself so didn't really have any idea how involved real world setups may or may not be, so wanted...

I did notice your use of `safe` for that option and am mostly okay with it but it really does put the onus on the user to properly format it...

I've tested this against both upcoming/ongoing live streams and can confirm this works and it hits `/live_chat` instead of `/live_chat_replay` so I can't reproduce what @xenova's running into, either.

@Indigo128 yes, you should keep your twitch-specific changes separate. this is usually why you should use separate branches (like `fix-youtube-oct-2025`) when opening PRs and not a main branch, but since...