Elias Lackner

Results 11 comments of Elias Lackner

I'm not sure if it's to late but I've added the missing blocks `sw_product_detail_cross_selling_empty_state_card` and `sw_product_detail_cross_selling_empty_state_actions` introduced in the two deprecations.

Are there any plans on this? It has been a while now. Currently it is not possible to get an easy Shopware 6.5 setup with the contribute image...

@tobiasberge I've removed the modal dialog and content blocks. The new blocks are now "overall", "header", "title", "close button", "body" and "back button". Is that okay?

Hey @leduc92 this has been Scheduled for a while now. Anything left to do here? Should I update the PR to the current changes, including Vue 3?

@marcelbrode Yes, I just don't really know what's missing. Did you add the Incomplete label because of the conflicting files?

@marcelbrode I'm sorry, I can't see any reviews. The reviewers sections shows "No reviews", too. So, definitely there's something wrong 😅

The reason for that behavior is that location.href doesn't stop script execution. The return statement inside the add method does indeed stop any execution inside that method but if you...

Well, both ways sound good to me. I'm just not fully aware of how that would work with ESI (never used it before) and what has to be changed for...

@runelaenen any intention to keep this repo alive?