Mateusz Łach

Results 15 comments of Mateusz Łach

[SdkSelfDiagnosticsEventListener](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/54984087e73407a4b6bac2c8c2b68bbd271d07f1/src/OpenTelemetry.AutoInstrumentation/Diagnostics/SdkSelfDiagnosticsEventListener.cs) fulfills similar purpose. I think with recent logging improvements to internal logger, this is no longer needed.

> @lachmatt I missed something earlier - I think this would cause an issue due to difference in versions. https://learn.microsoft.com/en-us/dotnet/api/system.uri.unescapedatastring?view=net-8.0#remarks > > Consider a service using old sdk injecting baggage...

> 1. There are two specs - 1. the [W3C Baggage Spec](https://www.w3.org/TR/baggage/), which is "W3C Working Draft" rather than "W3C Recommendation" 2. the [OpenTelemetry Baggage Spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/baggage/api.md), which is "Stable/Feature-freeze". There...

This should be reopened after https://github.com/open-telemetry/opentelemetry-dotnet/pull/5687 was merged.

@puckpuck This is a behavior of Kafka client instrumentation which is part of OTel .NET Autoinstrumentation. Semantic conventions for messaging recommend to create `receive` spans for [pull-based scenarios](https://github.com/open-telemetry/semantic-conventions/blob/507daf4bb9b9abe615bd641bbad248d810791177/docs/messaging/messaging-spans.md#consumer-spans). Most of...

> @RassK wouldn't that be better handled in a linked span, instead of a child span? Creation context is used as a parent, in addition to being added as a...

> @lachmatt - Could you please clarify where these requirements are coming from? > > * Only invalid baggage items are rejected during injection > * All of the baggage...

@vishweshbankwar I created an issue in the [spec](https://github.com/w3c/baggage/issues/137)

As this is something that can already be done by collector, as noted in this [comment](https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1962#issuecomment-2075526877), I think it'd be better to have consensus on this approach in broader opentelemetry...

SIG meeting: @Shereef We might need full exception or a repro to try help investigate the issue.