Lachlan Campbell
Lachlan Campbell
Ah, I believe that's the issue. Those custom properties are part of the color-modes package, which isn't included in core. What's your use case?
That makes sense! I was wondering why you wanted these custom properties though—I've personally never used them, since if I'm using Theme UI on a site typically all my styling...
Is there still a usecase/desire for non-color theme values to be accessible via custom properties?
Yep, we should totally cover this. As of now I don't understand all the moving parts of this well enough to write thorough documentation, but if someone else wants to...
We've significantly improved documentation on our JSX pragma, over here: https://theme-ui.com/guides/jsx-pragma Going to close this for now, but please flag if there's improvements we should make!
That’d be fantastic! We’d love a contribution of a guide. I’m unlikely to write one myself but happy to review/edit.
I vote we’re good to deprecate/make internal to docs! It’s been 6 months here without any pushback.
I'm also not really understanding the issue here. So we do generate all the custom properties in advance, explicitly so less JavaScript needs to run when the theme changes. But...
Ah, I see. I'm not sure the original idea, but my guess is it makes switching color modes faster: since the CSS has already been rendered & written to DOM...
@hasparus My read 2+ years later here is great TypeScript support is enough (which we've got other issues for improving)—I think of TypeScript as the default for most developers, &...