Lachlan

Results 60 comments of Lachlan

The work for this has been renamed to jetty-delegate, and is currently located [here](https://github.com/GoogleCloudPlatform/appengine-java-standard/tree/3.0.x/runtime/impl/src/main/java/com/google/apphosting/runtime/delegate) in the appengine-java-standard project, but we might decide to bring it back to Jetty at some...

I have run the same test with also adding an `AsyncListener` directly before adding the `WriteListener`. ```java AsyncContext asyncContext = req.startAsync(); asyncContext.addListener(new AsyncListener(){...}); ServletOutputStream out = response.getOutputStream(); out.setWriteListener(new WriteListener() {...

I have repeated this experiment after updating my test over Jetty/Tomcat/Undertow to what I believe are the latest servlet 6 versions. (Jetty-12.0.5, Tomcat-10.1.18, Undertow-2.3.10.Final) The test is setup like this:...

@Justvuur It means your URI has an empty segment (`//`) which makes it ambiguous. This is because it could be an attempt to bypass some security constraints. You can set...

@gregw with the change in behaviour to `SymlinkAllowedResourceAliasChecker`, now `testRelativeRedirect` and `testResourceRedirect` are failing from `ResourceHandlerTest`. They are expecting a request for `/context/dir/index.html/` will redirect to `/context/dir/index.html`, but now the...

> What is the additive behaviour of alias checkers? Does it just need to be approved by one? @gregw yes it just needs to be approved by one, so adding...

> We should not allow dir%2Findex.html just because we allow symlinks. This is exactly the kind of security constraint bypassing alias that the alias mechanism was implemented to protect against....

> If they add them symlink checker it should just allow Sym links and not arbitrary other aliases. The name says it! Well the name says `SymlinkAllowedResourceAliasChecker` not `SymlinkAliasChecker` and...

@gregw I'm not trying to combine them they already are. This is just how it is currently works. If you want to separate them then we're going to have to...