loam_velodyne icon indicating copy to clipboard operation
loam_velodyne copied to clipboard

Merge martin-velas contribution

Open laboshinl opened this issue 7 years ago • 3 comments

laboshinl avatar Mar 15 '17 08:03 laboshinl

This seems to have many new dependency requirements, have you been able to get it to build and run? If so, what improvements are added?

vkee avatar Aug 24 '17 13:08 vkee

I took a look to the change and I do definitively endorse to split the code in smaller functions with a readable name which clearly express the intent of the code.

I suggest @laboshinl to cherry pick here and there some changes to clean up his code.

By the way, Eigen is NOT a new dependency, since PCL already requires it.

facontidavide avatar Nov 25 '17 10:11 facontidavide

@laboshinl if we split this big PR in smaller one that you can review more easily, will you accept them? Do you have time to maintain the repository?

@martin-velas @StefanGlaser

facontidavide avatar Dec 14 '17 13:12 facontidavide