Shaun Guth

#148 add a note about potential upgrade issue with figaro [ci skip]

1

See issue #148 for more details 

Don't "require 'rails'" at require-time #205

1

This is a re-opening of PR #206 from a personal fork instead of my employer's fork.

A note about updating to 1.0.0

3

Had an issue today where values in config/application.yml were being skipped by Figaro when restarting our unicorn servers. At some point in the recent past our application was updated to...

We have a hybrid rails application + console application project that shares a common repository. The gems for the console application are segregated via Bundler group, and it is the...

Fix contains() for undefined argument

1

myEnum.contains(undefined) would throw an exception rather than return false, because the ! operator binds more tightly than instanceof

Don't fail on hostnames with '_' in them

4

At work today, we had a SOLR instance running on a domain name with an underscore in it: ``` URI::InvalidComponentError: bad component(expected host component): int-geocodes_domain-solr.practicefusion.net /var/www/geocode_domain/shared/bundle/ruby/2.2.0/gems/sunspot_rails-2.2.0/lib/sunspot/rails.rb:61:in `slave_config' /var/www/geocode_domain/shared/bundle/ruby/2.2.0/gems/sunspot_rails-2.2.0/lib/sunspot/rails.rb:38:in `build_session' ```...

This recording has been archived

1

The README has some external files it tries to load: 

I'd like to get `nil` when `xsi:nil="true"`, and a blank string when the tag is empty. ``` irb(main):025:0> parser = Nori.new(empty_tag_value: "") => #false, :delete_namespace_attributes=>false, :convert_tags_to=>nil, :convert_attributes_to=>nil, :empty_tag_value=>"", :advanced_typecasting=>true, :convert_dashes_to_underscores=>true,...

NameError: global name 'token' is not defined

1

Getting this when trying to request a movie: ``` 2018-05-03 01:12:17,287 (7f2194ff9700) : DEBUG (runtime:814) - Found route matching /video/requestchannel/5f6604060c803e5f327813454fedcfef/addmovierequest 2018-05-03 01:12:17,288 (7f2194ff9700) : CRITICAL (runtime:889) - Exception (most recent...

Multi-line regex formatted badly

1

Before: ``` [snip].... allow do origins %r{\A https?:// # allow http, or https (?:[a-zA-Z0-9] # optional subdomain [a-zA-Z0-9-]+ # [a-zA-Z0-9]\.)* # (#{hosts.join '|'}) # allowed hosts (?::(#{ports.join '|'}))? \z}x resource...