Mario Loriedo

Results 270 comments of Mario Loriedo
trafficstars

Faster than the wind 👍 Will review that later today.

@tolusha @sparkoo it would be great if you have time to have a look at the blog post too.

+1 to drop the machine-exec support. I expect that then we can also [re-enable shell integration](https://github.com/che-incubator/che-code/pull/90). But being able to open a terminal on a non-editor container and supporting Devfile...

We should also verify what was mentioned by @ibuziuk: user kubeconfig should continue to be automatically injected when starting a workspace from the dashboard.

And thanks @azatsarynnyy, great investigation.

Based on your feedback @nils-mosbach I think this is becoming critical. I am setting the priority to P1. The DevWorkspace controller cannot periodically refresh the tokens (its responsibility is to...

I would say that this issue is similar to https://github.com/eclipse/che/issues/21421 but for GitLab and Bitbucket.

I think we can split this in 2 separate issues: - Check OAuth tokens validity when workspace restarts (I have filed [this issue](https://github.com/eclipse/che/issues/21640)) - Periodically refresh a token from a...

@nils-mosbach thanks for your analysis and yes, you are right and I was wrong [about secrets that get updated automatically](https://kubernetes.io/docs/concepts/configuration/secret/#mounted-secrets-are-updated-automatically) (without the need to restart a workspace). I am still...

@nils-mosbach If you want to work on a PAT refresher VS Code extension I am happy with that. I prefer my team not to maintain that extra code but you...