che
che copied to clipboard
oAuth-proxy enhancements for Azure AKS deployment
Is your enhancement related to a problem? Please describe
There are several enhancements of ouath-proxy configuration (aka oauth-proxy.cfg) for kubernetes:
- To set
pass_access_tokentotrue(default value isfalse) to pass access token to upstream via "X-Forwarded-Access-Token" - To set
cookie_refreshto1h0m0sto refresh the cookie when duration has elapsed after cookie was initially set. - To add
whitelist_domainsto whitelist che domain (ie: .yourcompany.com) - To add
cookie_domainsto set cookie domain to force cookies to (ie: .yourcompany.com) - To add
OAuthScopeto Che Resource to allow users to configure Access Token Scope.
Describe the solution you'd like
Update che-operator to support addition configuration of ouath-proxy for kubernetes
Describe alternatives you've considered
No response
Release Notes Text
Some enhancements needed to deploy Che on Azure AKS has been contributed by @karatkep. Thank you for your contribution.
@karatkep thank you for this issue and the related contribution. Those enhancements were needed to deploy to AKS? And using the instructions in your repo are ment to be used by anyone trying to deploy to AKS?
I am asking because we are considering to:
- make this PR as a new and notworkthy addition to include in next release notes
- proposing you to contribute a blog post that explains how to deploy Che to AKS
Hi Mario, It's correct, the proposed enhancements were needed to deploy Che to Azure AKS. My instructions will be slightly updated because we found a more elegant way to solve reported issue during code review. Thanks to @tolusha and @sparkoo for the help.
And of course I will be glad to write a blog post and explain what issue we met and how it has been resolved in the new version of Che.
Best Regards, Piotr (aka karatkep)
On Thu, Jun 23, 2022 at 12:18 PM Mario Loriedo @.***> wrote:
@karatkep https://github.com/karatkep thank you for this issue and the related contribution. Those enhancements were needed to deploy to AKS? And using the instructions in your repo https://github.com/karatkep/che-aks-installer are ment to be used by anyone trying to deploy to AKS?
I am asking because we are considering to:
- make this PR as a new and notworkthy addition to include in next release notes
- proposing you to contribute a blog post that explains how to deploy Che to AKS
— Reply to this email directly, view it on GitHub https://github.com/eclipse/che/issues/21450#issuecomment-1164162788, or unsubscribe https://github.com/notifications/unsubscribe-auth/APGFNMECKJTQMPXWLEMCB63VQQTU3ANCNFSM5YG2FNCA . You are receiving this because you were mentioned.Message ID: @.***>
@karatkep I have added this issue in v7.50 release notes. If you have some instructions on how to deploy Che on Azure AKS please share so that we can make a blog post out of it. You may also submit a PR yourself on our blog github repository if you can, but that's not required.
@l0rd Please review https://github.com/eclipse-che/blog/pull/29
Faster than the wind 👍 Will review that later today.
@tolusha @sparkoo it would be great if you have time to have a look at the blog post too.
RN: upstream only
sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3845