Daniel Cazzulino

Results 360 comments of Daniel Cazzulino

Shocking, Roslyn isn't buying my fake symbol 😅 ![image](https://github.com/user-attachments/assets/07d8fcd1-05b7-4ebb-aab8-8488a926aa2c)

@ReubenBond should I give this a try or are you going to work on it soon-ish?

ok, I've spent some time understanding how things currently work in the generator. Do you want to keep the existing field accessor approach or should it be replaced wholesale with...

Hey @ReubenBond, I've got a question regarding [including primary ctor parameters](https://github.com/dotnet/orleans/blob/main/src/Orleans.CodeGenerator/CodeGenerator.cs#L245). The `GenerateSerializerAttribute` [states that](https://github.com/dotnet/orleans/blob/main/src/Orleans.Serialization.Abstractions/Annotations.cs#L14-L18) `IncludePrimaryConstructorParameters` will only default to `true` for record types. And the code uses `ITypeSymbol.IsRecord` to...

I think I got a potential fix 💪 https://github.com/dotnet/orleans/pull/9104

Almost two months to review a README PR. Seems like this thing is totally dead? Heya again @pelikhan 👋

![38 passed](https://img.shields.io/badge/✅-linux‐x64%20in%2012s-blue) ![38 passed](https://img.shields.io/badge/passed-38-brightgreen) :test_tube: Details on Ubuntu 24.04.3 LTS from [dotnet-retest](https://github.com/devlooped/dotnet-retest) v1.0.0 on .NET 10.0.0 with [:purple_heart:](https://github.com/sponsors/devlooped) by @devlooped

![38 passed](https://img.shields.io/badge/✅-linux‐x64%20in%2010s-blue) ![38 passed](https://img.shields.io/badge/passed-38-brightgreen) :test_tube: Details on Ubuntu 24.04.3 LTS from [dotnet-retest](https://github.com/devlooped/dotnet-retest) v1.0.0 on .NET 10.0.0 with [:purple_heart:](https://github.com/sponsors/devlooped) by @devlooped