Daniel Cazzulino

Results 360 comments of Daniel Cazzulino

@joelverhagen is there anything that can be done to avoid the new VS markdown preview (presumably that's the reason?) delaying this any longer?

I can do it if the cross-team thing has been resolved. Otherwise, we'll be in the same situation 4 months from now.

The second commit catches the cases of `new[] {` that were not flagged (nor autofixed) by the analyzers. The ambiguous API call compilation errors are due to not having the...

![80 passed](https://img.shields.io/badge/✅-linux‐x64%20in%204s-blue) ![80 passed](https://img.shields.io/badge/passed-80-brightgreen) :test_tube: Details on Ubuntu 24.04.3 LTS from [dotnet-retest](https://github.com/devlooped/dotnet-retest) v1.0.0 on .NET 10.0.0 with [:purple_heart:](https://github.com/sponsors/devlooped) by @devlooped

![80 passed](https://img.shields.io/badge/✅-linux‐x64%20in%203s-blue) ![80 passed](https://img.shields.io/badge/passed-80-brightgreen) :test_tube: Details on Ubuntu 24.04.3 LTS from [dotnet-retest](https://github.com/devlooped/dotnet-retest) v1.0.0 on .NET 10.0.0 with [:purple_heart:](https://github.com/sponsors/devlooped) by @devlooped

![80 passed](https://img.shields.io/badge/✅-linux‐x64%20in%203s-blue) ![80 passed](https://img.shields.io/badge/passed-80-brightgreen) :test_tube: Details on Ubuntu 24.04.3 LTS from [dotnet-retest](https://github.com/devlooped/dotnet-retest) v1.0.0 on .NET 10.0.0 with [:purple_heart:](https://github.com/sponsors/devlooped) by @devlooped

There's a bit of code duplication in the PR, but I tried to keep it in line with that was already there (i.e. the field accessor generation is also duplicated...

[Failed test](https://orleans.visualstudio.com/GitHub%20-%20PR%20Builds/_build/results?buildId=65466&view=logs&j=a914925e-a725-5e54-9e5f-f09f45aca578&t=61668551-dd17-5a6a-25c0-8710b6c853b4) seems unrelated: ``` [xUnit.net 00:00:09.23] UnitTests.StuckGrainTests.StuckGrainTests.StuckGrainTest_StuckDetectionOnDeactivation [FAIL] ``` It runs fine on my machine 🤔 Perhaps use [dotnet-retest](https://www.nuget.org/packages/dotnet-retest) 😉

Any updates on this @ReubenBond? This is blocking a release of my cloud actors thingy :)