kzhsw

Results 40 comments of kzhsw

Since many video container format, like `webm` in given example, could also include audio tracks, should the behavior of audio tracks in video files be standardized here? Behaviors might include...

Could be wasm heap OOM Related: https://github.com/kovacsv/occt-import-js/issues/30 See also

Another thing to discuss is in `dedupAnimationSamplers`, input and output are compared by reference, but `hashAnimationSampler` uses value hash, would it be better to have something like a Map-based reference...

> what use case do you have in mind for optimizing glTF files containing ~10,000 materials? Mostly models converted from other formats, FBX, STEP, IFC, and others. > Computing a...

With `simplifyWithAttributes` it should be possible to simplify with morph targets, so link issue #822 here. Also link #992 which is an old impl of attribute-aware simplify targeting meshoptimizer 0.21...

Would a "shallow hash" also be added here? A "shallow hash" hashes references instead of values for things like `RefSet`, `RefMap`. It can be implemented using a WeakMap, or add...

> Hm, I can't think of a reason that a shallow hash would be needed right now. For the use cases linked above, it would risk not matching deep duplicates....

> For that case, I believe we can reuse the same `cache` argument in `sampler.toHash(skip, cache)`, so when comparing animation samplers we'll already have cached hashes for the accessors precomputed....

Also, nodes with matrix would have the matrix [decomposed on loading](https://github.com/donmccurdy/glTF-Transform/blob/9bb441be72dc824917deafb00f8f1a06d00d14db/packages/core/src/io/reader.ts#L412), so the same thing could apply.

It's a transitive dependency from long unmantained [com.ecwid.consul:consul-api](https://github.com/Ecwid/consul-api), check https://github.com/spring-cloud/spring-cloud-consul/pull/840 for latest work on replacing this.